Skip to content

Commit

Permalink
Merge pull request #54 from j3-signalroom/github_issue-53
Browse files Browse the repository at this point in the history
Resolved #53.
  • Loading branch information
j3-signalroom authored Sep 6, 2024
2 parents 23fc1da + 753fb9a commit d042ebe
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ jobs:
TF_VAR_aws_access_key_id: ${{ steps.aws-credentials.outputs.aws-access-key-id }}
TF_VAR_aws_secret_access_key: ${{ steps.aws-credentials.outputs.aws-secret-access-key }}
TF_VAR_aws_session_token: ${{ steps.aws-credentials.outputs.aws-session-token }}
TF_VAR_service_account_user: ${{ github.event.inputs.service_account_user }}
TF_VAR_day_count: ${{ github.event.inputs.day_count }}

- name: Terraform Apply
Expand All @@ -103,4 +104,5 @@ jobs:
TF_VAR_aws_access_key_id: ${{ steps.aws-credentials.outputs.aws-access-key-id }}
TF_VAR_aws_secret_access_key: ${{ steps.aws-credentials.outputs.aws-secret-access-key }}
TF_VAR_aws_session_token: ${{ steps.aws-credentials.outputs.aws-session-token }}
TF_VAR_service_account_user: ${{ github.event.inputs.service_account_user }}
TF_VAR_day_count: ${{ github.event.inputs.day_count }}
6 changes: 6 additions & 0 deletions .github/workflows/undeploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ on:
- us-east-2
- us-west-1
- us-west-2
service_account_user:
type: string
description: Snowflake Service Account User
required: true

run-name: ${{ github.workflow }} ${{ github.ref_name }} branch to the ${{ github.event.inputs.aws_region }} ${{ github.event.inputs.aws_environment }} environment

Expand Down Expand Up @@ -75,6 +79,7 @@ jobs:
TF_VAR_aws_access_key_id: ${{ steps.aws-credentials.outputs.aws-access-key-id }}
TF_VAR_aws_secret_access_key: ${{ steps.aws-credentials.outputs.aws-secret-access-key }}
TF_VAR_aws_session_token: ${{ steps.aws-credentials.outputs.aws-session-token }}
TF_VAR_service_account_user: ${{ github.event.inputs.service_account_user }}

- name: Terraform Destroy Apply
id: apply_destroy
Expand All @@ -85,4 +90,5 @@ jobs:
TF_VAR_aws_access_key_id: ${{ steps.aws-credentials.outputs.aws-access-key-id }}
TF_VAR_aws_secret_access_key: ${{ steps.aws-credentials.outputs.aws-secret-access-key }}
TF_VAR_aws_session_token: ${{ steps.aws-credentials.outputs.aws-session-token }}
TF_VAR_service_account_user: ${{ github.event.inputs.service_account_user }}

4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.

The format is base on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.33.00.000] - 2024-09-06
### Fixed
- Passing `service_account_user` variable to the Terraform configuration in the GitHub Workflows.

## [0.32.00.000] - 2024-09-06
### Fixed
- Removed the unused `snowflake_user` variable in the BASH script and GitHub `deploy` Workflow/Action.
Expand Down

0 comments on commit d042ebe

Please sign in to comment.