Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest.json has an issue with icons array, "purpose": "any maskable" is not acceptable #6

Closed
vitalii-work opened this issue Nov 12, 2024 · 3 comments
Assignees

Comments

@vitalii-work
Copy link

When I tried to package our PWA for publishing in Google Play using PWABuilder, I got an error related to the icons array in manifest.json.

If your icons array includes a maskable icon, this must be included as a separate icon, and can’t be added as a dual icon type (like any maskable, for example). This is because using maskable icons as any can result in icons not being displayed optimally.
Source:
https://docs.pwabuilder.com/#/builder/manifest?id=icons

When I manually created manifest.json file (copied and pasted the content of the original manifest.json file generated by your PWA plugin) and updated the icons array, the issue disappeared and I was able to package our PWA.

Also, I have a question:

Why doesn't the plugin create the manifest.json file in the WP site root directory?
It would be useful to have it there to make edits when necessary.

@iworks iworks self-assigned this Nov 12, 2024
@iworks
Copy link
Owner

iworks commented Nov 12, 2024

@vitalii-work

Why doesn't the plugin create the manifest.json file in the WP site root directory?

There is no file. It is dynamically generated (with cache).

@vitalii-work
Copy link
Author

@iworks, what if changing the logic of the plugin to generate a real manifest.json file will be a solution to another issue #5 (The “manifest.json” file is no reachable.")?

iworks added a commit that referenced this issue Nov 12, 2024
…" is not acceptable #6

#6
ERROR in initial install/setup #5
#5
@iworks
Copy link
Owner

iworks commented Nov 12, 2024

Thank you! It should be fixed here: https://github.com/iworks/iworks-pwa/releases/tag/1.6.5

@iworks iworks closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants