Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded .clone() call #190

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Remove unneeded .clone() call #190

merged 1 commit into from
Nov 3, 2023

Conversation

p-l-
Copy link
Member

@p-l- p-l- commented Oct 18, 2023

pattern is a reference, and according to cargo test output: "the type [u8] does not implement Clone, so calling clone on &[u8] copies the reference, which does not do anything and can be removed".

`pattern` is a reference, and according to `cargo test` output: "the
type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]`
copies the reference, which does not do anything and can be removed".
@p-l- p-l- requested a review from Frky October 18, 2023 00:28
Copy link
Member

@Frky Frky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Frky Frky merged commit 9e23e34 into ivre:master Nov 3, 2023
2 checks passed
@p-l- p-l- deleted the fix-warning branch November 3, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants