Avoid GC_suspend aborting due to deleted thread #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
035756a to
bd38c40
Compare
A thread may be deleted by a DllMain call during execution of GC_suspend. This patch sets the handle to be NULL when deleting the thread to avoid use-after-free bugs, and skips the GC_suspend attempt if the thread handle has been closed.
bd38c40 to
8df263b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A thread may be deleted by a DllMain call during execution of GC_suspend.
This patch sets the handle to be NULL when deleting the thread to avoid use-after-free bugs, and skips the GC_suspend attempt if the thread handle has been closed.
Fixes #704