Merge pull request etcd-io#17117 from silves-xiang/main

etcdclient: Fix memory leak caused by for + time.After
ivanvc · Dec 14, 2023 · 2cf112f · 2cf112f
2 parents a70fa9b + ed01ee1
commit 2cf112f
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/client/v3/lease.go b/client/v3/lease.go
@@ -549,9 +549,12 @@ func (l *lessor) recvKeepAlive(resp *pb.LeaseKeepAliveResponse) {
 // deadlineLoop reaps any keep alive channels that have not received a response
 // within the lease TTL
 func (l *lessor) deadlineLoop() {
+	timer := time.NewTimer(time.Second)
+	defer timer.Stop()
 	for {
+		timer.Reset(time.Second)
 		select {
-		case <-time.After(time.Second):
+		case <-timer.C:
 		case <-l.donec:
 			return
 		}