Develop #88

ivanceras · 2024-03-30T16:15:31Z

struct DomNode as a wrapper to the web_sys::Node, this allows custom behaviour on StatefulComponent
improvment on SkipDiff with SkipAttrs strategy which specifies specific attribute to skip.
remove inner_html as it breaks the tracking of dom tree
make safe_html use parsing of html for safely adding html into the dom.
add Symbol variant for the Leaf which is specifically intended to be used for html-entities
remove the use of VDOM-DATA-ID and counter since tracking of closures is already in the DomNode
improve templating

…nent as it is superseeded by the use of TemplatedView which provides the same functionality

…as it can be acquired from the comp view itself

…it can be acquired from calling the Applications view

…unt event on the children elements

…override the previously set attribute with the same name

…e how patches are handled to their underlying nodes

…o modify the DomTree, this is needed for custom modification on stateful component

…web_sys::Node

…n each DomNode

…ow_event_listeners into Task counterpart in the Window functions

…fix deep_clone also for children

… that are to be skipped

…sing it around

… children

…ove debug logging

…ement rather than replacing the whole thing with a new Rc<RefCell<Some(listener)>>>

…e clone and shared and passed into children

ivanceras added 30 commits March 21, 2024 13:31

feat: remove skip_diff and template method from Application and Compo…

87a4792

…nent as it is superseeded by the use of TemplatedView which provides the same functionality

refactor: remove skip_diff and vdom_template from StatelessComponent …

ad101f8

…as it can be acquired from the comp view itself

fix: map the TemplatedView variant of Leaf

b03af8e

fix: remove template, skip_diff and vdom_template from AppContext as …

0377cf5

…it can be acquired from calling the Applications view

cleanup: remove unused objects

b42aab2

docs

a03cce1

doc: more TODO items

17bf494

fix: examples

8855b41

fix: creating the initial view from the template should still fire mo…

6536786

…unt event on the children elements

cargo fmt

e4cee32

fix:tests

f42373d

fix: remove deny warnings on tests

f9701e2

doc

8366eab

fix: AddAttributes patch to merge the attributes first, so as not to …

b135fda

…override the previously set attribute with the same name

change defaults

bf48417

fix: remove more debugs

cbcc8dc

fix: stateless component should not have attributes or children

8bb8045

feat: make a DomNode counterpart to vdom::Node to be able to customiz…

68bf04a

…e how patches are handled to their underlying nodes

feat: wrap the web_sys::Node into DomNode for better control on how t…

ae4114d

…o modify the DomTree, this is needed for custom modification on stateful component

feat: implement the methods of the DomNode which is a wrapper to the …

8439759

…web_sys::Node

fix: set the parent for appended elements

f5504c4

fix: remove node_closures, as the the event listeners is now stored i…

4c57e26

…n each DomNode

fix: Task now carries the associated event closures, convert add_wind…

84a65ca

…ow_event_listeners into Task counterpart in the Window functions

fix: put back stateless component and stateful component

9a96949

fix: return the first_node on replace_node when patch_path is empty, …

d985209

…fix deep_clone also for children

fix: don't use templating for stateless component for now

495aa2b

fix: put a boolean flag whether to use template or not

88c62ad

fix: remove closures and event_closures

c0aa4f3

fix: move SkipPath into SkipDiff

76569d7

more cleanup and optimization

68099ba

ivanceras added 29 commits March 29, 2024 21:05

feat: improve SkipDiff with inclusion of specific index of attributes…

fb611d3

… that are to be skipped

fix: and simplify the is_subset_of function

a478884

cargo fmt

84fa5f8

fix: add allow(unused_braced) in for loop

33bb3b1

fix: no need to track the selected_id

7b4437e

fix: deep_clone which fix the templating, fix setting parent node

d83577c

refactor: set parent directly instead of borrowing and setting

d49322c

fix: set the root_node in the apply_dom_patch function instead of pas…

7bfb4aa

…sing it around

fix: parent need not to be mutable RefCell

0d61123

fix: TextNode and Symbol dont need inner mutability

17d3ba1

feat: make applying dom patches as mutable methods

366cb8c

fix edge case of replace node when root node is replaced with multipe…

cf0fcc5

… children

cleanup: replace_node patch

50a5b09

fix: dont use raf in test_fixture when updating dom with patches, rem…

53eb114

…ove debug logging

fix: disable the add_event test for now

a0aceab

use template

3180d09

fix: adding event by using inner mutability to the listeners of an el…

6f45f23

…ement rather than replacing the whole thing with a new Rc<RefCell<Some(listener)>>>

feat: put the usage of skipdiff behind use-skipdiff feature gate

5cd5c91

feat: add PartialEq implementation for DomNode

77eb2b2

cargo fmt

62d2d81

fix: use partial eq checking for comparing children to be removed

b06880c

fix: the parent_node passed should be Rc<Option<DomNode>> so it can b…

0895a25

…e clone and shared and passed into children

use-skipdiff but not template and its much faster

7b8fac7

fix: display the time_spent and clear afterwards

6b3c362

doc: update TODO with new rethink about Cmd and Task

0632d40

doc: more docs and TODO

5c9ceaf

doc: TODO

77da86c

fix: remove more logging

2b2d365

fix: only store the Event closures

06b335a

ivanceras merged commit 5dbf299 into master Apr 1, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop #88

Develop #88

ivanceras commented Mar 30, 2024

Develop #88

Develop #88

Conversation

ivanceras commented Mar 30, 2024