[SPRINT5] Client Refactoring Part-2 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
siboxd
commented
Jul 29, 2018
- Better refactored ClientControllerActor
- Added an hierarchy to Common actor messages
- Added a way to prematurely stop "participant receiver" server
- Refactored FXAlertsController
- Renamed some classes and methods to make their function more comprehensible
- Moved only to actors view loadings and components enabling management
and better separated loading dialogs creation
…ticationViewActor
…iew actors) - Removed abnormal behaviour of loading dialogs in FXServiceViewActor
… view actor - Renamed a method in FXServiceViewActor
… showing the provided message
- Added type hierarchy to Rooms messages
- Prepared messages to be managed by controller actor to shut down one-time server and exit room online
- Prepared ClientController for next developments
…r on entering a room
DavideBorficchia
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.