Primary documents #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 28, 2023 10:28
| @@ -39,14 +41,27 @@ class InvertedIndex(private val standProperties: StandProperties) : LuceneReposi | |||
| entities.forEach { save(it) } | |||
| } | |||
|
|
|||
| fun findByTokens(tokens: Collection<String>): Sequence<NeighboursDocument> { | |||
There was a problem hiding this comment.
тут еще можно буст квери использовать, как вот в этой функции Артема:
наверное зря мы туда засунули analyze, можно обобщить функцию BoW query
| @@ -68,6 +68,7 @@ class InvertedIndexBuilder( | |||
| documentEmbeddingRepository.findByDocId(docId).embedding | |||
| } | |||
| NeighboursDocument( | |||
| token = contextualizedEmbedding.tokenWithEmbeddingId.split(ContextualizedEmbedding.TOKEN_AND_EMBEDDING_ID_SEPARATOR).first(), | |||
There was a problem hiding this comment.
выглядит кривовато, что мы одно поле парсим и в тот же объект складываем результат.
как proof of concept норм
но думаю, если решим мержить, то можно что-нибудь придумать с этим
added 2 commits
May 29, 2023 21:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.