Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts for building TFLite for Risc-V #446

Merged

Conversation

PPlastova
Copy link
Contributor

No description provided.

FenixFly
FenixFly previously approved these changes Nov 23, 2023
@@ -0,0 +1,35 @@
# TFLite build for Linux RISC-V platform
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

После заголовка и между текстом кодом должна быть пустая строка. Проверьте, пожалуйста.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предлагаю скрипты сборки разместить в src/build_scripts/tflite/risc-v по аналогии с openvino.

# TFLite build for Linux RISC-V platform
Build and install prerequisites for cpp dl tflite launcher build:
```bash
# Into dl-benchmark/src/build_scripts/tflite directory:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предлагаю подобные комментарии заменить на переход в директорию.

cd dl-benchmark/src/build_scripts/tflite

@@ -0,0 +1,35 @@
# TFLite build for Linux RISC-V platform
Build and install prerequisites for cpp dl tflite launcher build:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо избавиться от сокращений и написать что-то вроде: Build and install prerequisites for TensorFlow Lite launcher (CPP API). По аналогии везде по тексту.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Имеет смысл инструкцию оформить в виде списка.

mkdir builded_launcher && tar -xvzf riscv64_send_archive.tgz -C builded_launcher
```

Set LD_LIBRARY_PATH to builded packages and sysroot:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set LD_LIBRARY_PATH to builded packages and sysroot:

@valentina-kustikova
Copy link
Contributor

Сборка Python API планируется сюда же добавить или пойдет отдельно?

@valentina-kustikova
Copy link
Contributor

@PPlastova, внесите, пожалуйста, исправления, чтобы можно было замержить. Спасибо!

@valentina-kustikova
Copy link
Contributor

@PPlastova, внесла небольшие правки по форматированию readme прямо в вашу ветку.

@FenixFly, посмотри, пожалуйста.

@valentina-kustikova valentina-kustikova merged commit 8c71f7a into itlab-vision:master Dec 18, 2023
4 checks passed
ismukhin pushed a commit to ismukhin/dl-benchmark that referenced this pull request Dec 23, 2023
Co-authored-by: Polina Plastova <p.plastova@yadro.com>
Co-authored-by: Valentina <valentina-kustikova@users.noreply.github.com>
ismukhin added a commit to ismukhin/dl-benchmark that referenced this pull request Dec 23, 2023
@PPlastova PPlastova deleted the pplastova_riscv_tflite branch May 4, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants