-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts for building TFLite for Risc-V #446
Scripts for building TFLite for Risc-V #446
Conversation
src/build_scripts/tflite/README.md
Outdated
@@ -0,0 +1,35 @@ | |||
# TFLite build for Linux RISC-V platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
После заголовка и между текстом кодом должна быть пустая строка. Проверьте, пожалуйста.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Предлагаю скрипты сборки разместить в src/build_scripts/tflite/risc-v по аналогии с openvino.
src/build_scripts/tflite/README.md
Outdated
# TFLite build for Linux RISC-V platform | ||
Build and install prerequisites for cpp dl tflite launcher build: | ||
```bash | ||
# Into dl-benchmark/src/build_scripts/tflite directory: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Предлагаю подобные комментарии заменить на переход в директорию.
cd dl-benchmark/src/build_scripts/tflite
src/build_scripts/tflite/README.md
Outdated
@@ -0,0 +1,35 @@ | |||
# TFLite build for Linux RISC-V platform | |||
Build and install prerequisites for cpp dl tflite launcher build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Необходимо избавиться от сокращений и написать что-то вроде: Build and install prerequisites for TensorFlow Lite launcher (CPP API). По аналогии везде по тексту.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Имеет смысл инструкцию оформить в виде списка.
src/build_scripts/tflite/README.md
Outdated
mkdir builded_launcher && tar -xvzf riscv64_send_archive.tgz -C builded_launcher | ||
``` | ||
|
||
Set LD_LIBRARY_PATH to builded packages and sysroot: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set LD_LIBRARY_PATH
to builded packages and sysroot
:
Сборка Python API планируется сюда же добавить или пойдет отдельно? |
@PPlastova, внесите, пожалуйста, исправления, чтобы можно было замержить. Спасибо! |
…into pplastova_riscv_tflite
@PPlastova, внесла небольшие правки по форматированию readme прямо в вашу ветку. @FenixFly, посмотри, пожалуйста. |
Co-authored-by: Polina Plastova <p.plastova@yadro.com> Co-authored-by: Valentina <valentina-kustikova@users.noreply.github.com>
This reverts commit bbff0a2.
No description provided.