Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff: handle granular targets #9980

Merged
merged 2 commits into from
Sep 28, 2023
Merged

diff: handle granular targets #9980

merged 2 commits into from
Sep 28, 2023

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Sep 26, 2023 •
edited
Loading

Fixes #9507

@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
tests/func/test_diff.py 100.00% <100.00%> (ø)
dvc/repo/index.py 85.92% <97.77%> (+1.25%) ⬆️
dvc/repo/diff.py 93.33% <80.00%> (-2.19%) ⬇️

📢 Thoughts on this report? Let us know!.

@efiop efiop changed the title index: check parents when trying to detect hash_name diff: handle granular targets Sep 27, 2023
@efiop efiop marked this pull request as draft September 27, 2023 00:47
@efiop efiop changed the title diff: handle granular targets [WIPdiff: handle granular targets Sep 27, 2023
@efiop efiop changed the title [WIPdiff: handle granular targets [WIP] diff: handle granular targets Sep 27, 2023
@efiop efiop force-pushed the fix-9507 branch 6 times, most recently from a8cbcf1 to a1b1d21 Compare September 28, 2023 15:46
@efiop efiop marked this pull request as ready for review September 28, 2023 16:52
@efiop efiop changed the title [WIP] diff: handle granular targets diff: handle granular targets Sep 28, 2023
@efiop efiop merged commit 4d5a016 into iterative:main Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

diff: output after partial pull wrongfully includes top dir
1 participant
@efiop