-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snap: build fixes #3990
Merged
Merged
snap: build fixes #3990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hmm Travis has a radically different guide suggesting docker, which concludes on the next page to check out Let's just say nothing is documented anywhere. |
Related: iterative#3872
@efiop ready for merge |
Thank you @casperdcl ! 🙏 |
casperdcl
added a commit
to casperdcl/dvc
that referenced
this pull request
Jun 9, 2020
Related iterative#3990 Related iterative#3989
6 tasks
efiop
pushed a commit
that referenced
this pull request
Jun 13, 2020
* snap: drop sudo Fixes #3989 * snap: ci: fix builds * snap: ci: developer notifications * snap: minimise size * debug commit * Revert "snap: minimise size" This reverts commit 77b41a9. * fix image info * Revert "debug commit" This reverts commit 232baf0. * snap: v1 channels Related: #3872 * snap: v0 channels Related #3990 Related #3989 * snap: auto-version (major) detect * ci: fetch --tags explanation & error checking * snap: update warning framework * hardocde warning * add deprecation dev comment * remove warning on explicit v0 channel * tidy comment * fix py2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snapcraft --use-lxd
builds withoutsudo
v1
snap channels snap: transition to v1 #3872reduce snap size https://forum.snapcraft.io/t/reducing-the-size-of-desktop-snaps/17280doesn't work withplugin: python
(also barely reduces size in this case - 107MB vs 97MB)