Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: always show json #10253

Merged
merged 2 commits into from
Jan 24, 2024
Merged

status: always show json #10253

merged 2 commits into from
Jan 24, 2024

Conversation

dberenbaum
Copy link
Collaborator

Fixes #10242. This it so that dvc status -q --json returns JSON and only JSON. Without this PR, dvc status -q --json returns only an exit code, and dvc status --json included non-critical logger output in addition to JSON, so there was no way to guarantee that stdout would return valid JSON.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18a9fea) 90.50% compared to head (8458acb) 90.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10253      +/-   ##
==========================================
- Coverage   90.50%   90.49%   -0.02%     
==========================================
  Files         493      493              
  Lines       37643    37643              
  Branches     5457     5457              
==========================================
- Hits        34069    34064       -5     
- Misses       2950     2953       +3     
- Partials      624      626       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@efiop efiop merged commit 20edd72 into main Jan 24, 2024
24 checks passed
@efiop efiop deleted the status-json branch January 24, 2024 01:09
BradyJ27 pushed a commit to BradyJ27/dvc that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dvc status --json can output non-json
2 participants