index: data_tree: handle partial imports #10221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
commented
Jan 4, 2024
| @@ -271,7 +271,7 @@ def test_pull_partial_import(tmp_dir, dvc, local_workspace): | |||
| stage = dvc.imp_url("remote://workspace/file", os.fspath(dst), no_download=True) | |||
|
|
|||
| result = dvc.pull("file") | |||
| assert result["fetched"] == 0 | |||
| assert result["fetched"] == 1 | |||
There was a problem hiding this comment.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10221 +/- ##
==========================================
- Coverage 90.48% 90.21% -0.27%
==========================================
Files 499 499
Lines 37994 38008 +14
Branches 5521 5522 +1
==========================================
- Hits 34379 34290 -89
- Misses 2971 3052 +81
- Partials 644 666 +22 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if one has partial import and then also does partial update (--no-download), dvc will think that this is the same data tree and will hit cached index, resulting in invalid state.
Fixes #10173