repro --pull: always pull deps #10187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10187 +/- ##
=======================================
Coverage 90.62% 90.62%
=======================================
Files 499 499
Lines 37900 37907 +7
Branches 5508 5508
=======================================
+ Hits 34346 34354 +8
Misses 2912 2912
+ Partials 642 641 -1 ☔ View full report in Codecov by Sentry. |
|
Ping @iterative/dvc. This addresses a customer issue, so PTAL so we can get it merged. |
efiop
approved these changes
Jan 18, 2024
|
Sorry for such a long wait 😞 |
efiop
approved these changes
Jan 18, 2024
|
Thanks @efiop! |
BradyJ27
pushed a commit
to BradyJ27/dvc
that referenced
this pull request
Apr 22, 2024
* repro --pull: always pull deps * drop unused allow_missing args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://iterativeai.slack.com/archives/C03JS2V4MQU/p1702982308956539.
repro --pullwas pulling outputs but not dependencies (unless--allow-missingwas also passed). This normally is enough, but in cases likerepro --pull --single-item, the output from the previous stage is never pulled, causing the command to fail. This PR pulls dependencies whenever--pullis included.