Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: bench: use --dataset instead of --size #10134

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Dec 4, 2023

This is no longer just about size (e.g. we have mnist/openorca/used-cars), so the --dataset makes more sense.

This is no longer just about size (e.g. we have mnist/openorca/used-cars),
so the --dataset makes more sense.
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c0b64b0) 90.60% compared to head (b9d6f6c) 90.37%.

Files Patch % Lines
dvc/testing/benchmarks/plugin.py 0.00% 3 Missing ⚠️
dvc/testing/benchmarks/fixtures.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10134      +/-   ##
==========================================
- Coverage   90.60%   90.37%   -0.24%     
==========================================
  Files         494      494              
  Lines       37639    37639              
  Branches     5478     5478              
==========================================
- Hits        34104    34016      -88     
- Misses       2896     2963      +67     
- Partials      639      660      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop efiop merged commit e18fd34 into iterative:main Dec 4, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant