tests: do not setup pytest plugin entrypoint #10121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not register a pytest plugin automaticallly, as we may have fixtures that might override user's fixtures. Also, it might raise import errors as in iterative#10118. We can still use this as a plugin ourselves by setting the following in `conftest.py` file. ```python pytest_plugins = ['dvc.testing.plugin'] ```
pmrowla
approved these changes
Nov 29, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10121 +/- ##
==========================================
+ Coverage 90.56% 90.66% +0.10%
==========================================
Files 488 488
Lines 37392 37425 +33
Branches 5434 5442 +8
==========================================
+ Hits 33864 33932 +68
+ Misses 2892 2857 -35
Partials 636 636 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not register a pytest plugin automatically, as we may have fixtures that might override user's fixtures. Also, it might raise import errors as in #10118.
We can still use this as a plugin ourselves by setting the following in
conftest.pyfile.