Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add params collection to index #10086

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Add params collection to index #10086

merged 2 commits into from
Nov 14, 2023

Conversation

shcheklein
Copy link
Member

@shcheklein shcheklein commented Nov 11, 2023 •
edited
Loading

Add param files collection to index to implement:

downloaded_cnt = repo.fetch(
           ...
            types=["metrics", "plots", "params"],
            ...
        )

It's not used anywhere atm and needed to potentially migrate Studio code to use Index.

TODO

  • Add tests. Do we have any tests for index at all @skshetry @efiop? I don't see anything, and plan to add unit/test_index or something like that. Found the repo_index one.

@shcheklein shcheklein added enhancement Enhances DVC A: data-management Related to dvc add/checkout/commit/move/remove labels Nov 11, 2023
@shcheklein shcheklein self-assigned this Nov 11, 2023
@shcheklein shcheklein changed the title Add params collection to index [WIP] Add params collection to index Nov 11, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
tests/func/test_repo_index.py 96.80% <100.00%> (+0.25%) ⬆️
dvc/repo/index.py 86.23% <88.23%> (+0.07%) ⬆️

📢 Thoughts on this report? Let us know!

@shcheklein shcheklein changed the title [WIP] Add params collection to index Add params collection to index Nov 11, 2023
@shcheklein
Copy link
Member Author

@iterative/dvc can we please review this?

@efiop efiop merged commit 86dd078 into main Nov 14, 2023
20 checks passed
@efiop efiop deleted the add-params-to-index branch November 14, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop approved these changes

@skshetry skshetry Awaiting requested review from skshetry

@pmrowla pmrowla Awaiting requested review from pmrowla

Assignees

@shcheklein shcheklein

Labels
A: data-management Related to dvc add/checkout/commit/move/remove enhancement Enhances DVC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shcheklein @efiop