import/get: support pre-fetching LFS objects from Git-LFS repos #10072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22604f6 to
81afb7a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10072 +/- ##
=======================================
Coverage 90.56% 90.56%
=======================================
Files 488 488
Lines 37392 37422 +30
Branches 5434 5441 +7
=======================================
+ Hits 33864 33892 +28
- Misses 2892 2893 +1
- Partials 636 637 +1 ☔ View full report in Codecov by Sentry. |
b1b16a6 to
8355c58
Compare
dberenbaum
approved these changes
Nov 28, 2023
8355c58 to
a76f469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Requires iterative/scmrepo#278
Related: #9175
Example import from https://huggingface.co/stabilityai/stable-diffusion-xl-base-1.0/tree/main/text_encoder:
LFS objects are only downloaded once (during the "Checking for LFS objects" step). The second "Downloading" message in the recording is the generic import/get status and is actually the reads from GitFilesystem (and not a network transfer).