Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon: ipc to log pid from the child #10058

Merged
merged 3 commits into from
Oct 30, 2023
Merged

daemon: ipc to log pid from the child #10058

merged 3 commits into from
Oct 30, 2023

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Oct 30, 2023 •
edited
Loading

This will be useful in log messages and while attaching debugger to the child process (and also to see the processes in task managers).

Also reduces chances of tests being flakey, and retries.

2023-10-30 11:40:13,671 DEBUG: Spawned ['daemon', 'analytics', '/tmp/tmp9tj3fsb0', '-vv'] with pid 69118

@skshetry skshetry added the skip-changelog Skips changelog label Oct 30, 2023
@skshetry skshetry requested review from pmrowla and efiop October 30, 2023 05:56
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
tests/func/test_daemon.py 100.00% <100.00%> (+2.35%) ⬆️
dvc/daemon.py 58.65% <75.00%> (-0.53%) ⬇️

📢 Thoughts on this report? Let us know!.

@skshetry skshetry merged commit 89b4beb into iterative:main Oct 30, 2023
20 checks passed
@skshetry skshetry deleted the ipc-child-pid branch October 30, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrowla pmrowla pmrowla approved these changes

@efiop efiop Awaiting requested review from efiop

Assignees
No one assigned
Labels
skip-changelog Skips changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skshetry @pmrowla