Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locked warning is shown for all files in dvc status #927

Closed
prihoda opened this issue Jul 20, 2018 · 2 comments
Closed

Locked warning is shown for all files in dvc status #927

prihoda opened this issue Jul 20, 2018 · 2 comments
Assignees
Labels
bug Did we break something?
Milestone

Comments

@prihoda
Copy link
Contributor

prihoda commented Jul 20, 2018

Hi there, the locked file warning seems to be shown for all files in dvc status:

git init
dvc init
git add .dvc 

# Create example folder
mkdir example
cd example

# Create hello.txt and world.txt
dvc run -o hello.txt 'yes "Hello" | head -10 > hello.txt'
dvc run -o world.txt 'yes "World" | head -10 > world.txt'

# Merge into hello_world.txt
dvc run -d hello.txt -d world.txt -o hello_world.txt 'paste hello.txt world.txt > hello_world.txt'

## Running command:
## 	yes "Hello" | head -10 > hello.txt
## Running command:
## 	yes "World" | head -10 > world.txt
## Running command:
## 	paste hello.txt world.txt > hello_world.txt

dvc status
## DVC file 'hello.txt.dvc' is locked. Its dependecies are not going to be shown in status output.
## DVC file 'world.txt.dvc' is locked. Its dependecies are not going to be shown in status output.
## DVC file 'hello_world.txt.dvc' is locked. Its dependecies are not going to be shown in status output.
## hello.txt.dvc
## world.txt.dvc

cat hello_world.txt.dvc 
## cmd: paste hello.txt world.txt > hello_world.txt
## deps:
## - md5: 2b360db687b5870bd328adbb56d3bf8f
##   path: hello.txt
## - md5: 53d23c8121564867f8ee222841a83811
##   path: world.txt
## md5: e1e60249c4f84c11cda133706d649e31
## outs:
## - cache: true
##   md5: 1abddce536be836e612dedc0a272b86f
##   metric: false
##   path: hello_world.txt
@prihoda
Copy link
Contributor Author

prihoda commented Jul 20, 2018

Actually, it's shown for the non-locked files 😄

The bug is in project.status:

        for stage in stages:
            if not stage.locked:

@efiop
Copy link
Contributor

efiop commented Jul 20, 2018

Oops, sorry 🙂 I'll fix it ASAP, will be included into 0.14.1 release today.

Thank you!

@efiop efiop self-assigned this Jul 20, 2018
@efiop efiop added the bug Did we break something? label Jul 20, 2018
@efiop efiop added this to the Queue milestone Jul 20, 2018
efiop added a commit to efiop/dvc that referenced this issue Jul 20, 2018
Fixes iterative#927

Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something?
Projects
None yet
Development

No branches or pull requests

2 participants