hashfiledb: remove unused HashFileDB.config #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
==========================================
- Coverage 63.76% 63.58% -0.19%
==========================================
Files 61 61
Lines 4176 4193 +17
Branches 714 715 +1
==========================================
+ Hits 2663 2666 +3
- Misses 1367 1381 +14
Partials 146 146 ☔ View full report in Codecov by Sentry. |
efiop
reviewed
Dec 30, 2023
src/dvc_data/hashfile/db/__init__.py
Outdated
| self.fs, | ||
| HashInfo(self.hash_name, oid), | ||
| ) | ||
| return HashFile(self.oid_to_path(oid), self.fs, HashInfo(self.hash_name, oid)) |
There was a problem hiding this comment.
Looks like we are missing some rule for ruff?
There was a problem hiding this comment.
I think I changed that myself. I probably should not have. will revert.
7673a1e to
4d904c6
Compare
efiop
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__init__signature to matchObjectDB.