Add WithoutNormalize Compiler Option #274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This additional option makes to run gojq code concurrent against the same data without requiring a mutex. gojq won't try to write and modify the given data if the new option is specified. However one needs to manually normalize the data or make sure it has the right format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
WithoutNormalizecompile option to the gojq compiler. When the option has been specified, data given to gojq won't be normalized, and therefore modified.I ran into this issue when running many queries concurrent against a single set of data. It's not useful to normalize the data over and over again and also the only other to options are to either (a) hold a lock while running gojq or (b) creating copies of the data. I understand it makes sense to have this as a default but adding this option gives greater control over how, when and if the given data should be modified.