fix crash on multiplying too large number to a string

itchyny · Aug 9, 2020 · 05129e3 · 05129e3
1 parent ea6aea5
commit 05129e3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/cli/test.yaml b/cli/test.yaml
@@ -1792,7 +1792,7 @@
 
 - name: multiply strings
   args:
-    - '[-1.0, -0.5, 0.0, 0.5, 1.0, 1.5, 3.7, 10, 9444732965739290427392 / 4722366482869645213696, infinite][] * "abc"'
+    - '[-1.0, -0.5, 0.0, 0.5, 1.0, 1.5, 3.7, 10, 9444732965739290427392 / 4722366482869645213696, 1000000000, infinite][] * "abc"'
   input: 'null'
   expected: |
     null
@@ -1805,6 +1805,7 @@
     "abcabcabcabcabcabcabcabcabcabc"
     "abcabc"
     null
+    null
 
 - name: multiply objects
   args:

diff --git a/operator.go b/operator.go
@@ -375,7 +375,7 @@ func funcOpMul(_, l, r interface{}) interface{} {
 		deepMergeObjects,
 		func(l, r interface{}) interface{} {
 			multiplyString := func(s string, cnt float64) interface{} {
-				if cnt <= 0.0 || int(cnt) < 0 {
+				if cnt <= 0.0 || int(cnt) < 0 || int(cnt) > maxHalfInt/(16*len(s)) {
 					return nil
 				}
 				if cnt < 1.0 {