Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secret for grafana credentials #2441

Closed
howardjohn opened this issue Feb 27, 2020 · 5 comments
Closed

Add secret for grafana credentials #2441

howardjohn opened this issue Feb 27, 2020 · 5 comments

Comments

@howardjohn
Copy link
Member

For istio/istio#21541 we will need grafana credentials in the cluster. This will be used by the release builder.

I am not sure if there is a standard practice for how we handle these secrets in the cluster?

@howardjohn
Copy link
Member Author

This is not particularly urgent, by the way, timeline for this is 1.6 which is released in 3 months. I still need to write all the code to handle this anyways

@clarketm
Copy link
Member

clarketm commented Feb 27, 2020

There is currently an issue tracking the proposal for a standard, declarative, secret manager tool/service (kubernetes/test-infra#14049).

The current practice is to backup the secret value in an external data store, manually upload the value as a Kubernetes secret in the cluster(s), and optionally create a Prow preset for convenience (if applicable).

@howardjohn
Copy link
Member Author

In this specific case we only need it on one job so preset is probably not really needed

@clarketm
Copy link
Member

clarketm commented Mar 2, 2020

Created secret grafana-token with key token in test-pods namespace of istio-prow-build cluster.

@clarketm clarketm closed this as completed Mar 2, 2020
@howardjohn
Copy link
Member Author

howardjohn commented Mar 2, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants