Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: improve wildcard matching (#11921) (#11929) #233

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

duderino
Copy link

@duderino duderino commented Jul 7, 2020

Patching in 11885 with runtime guards and release notes

Risk Level: Medium (changes to cert matching)
Testing: new unit test
Docs Changes: n/a
Release Notes: inline
Runtime guard: envoy.reloadable_features.fix_wildcard_matching

Signed-off-by: Yann Soubeyrand yann.soubeyrand@camptocamp.com
Signed-off-by: Alyssa Wilk alyssar@chromium.org
Signed-off-by: Piotr Sikora piotrsikora@google.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

@@ -10,6 +10,18 @@ Version history
active/accepted connections.
* overload management: add runtime support for :ref:`global limits <config_overload_manager>`
on active/accepted connections.
1.14.4 (July 7, 2020)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and here)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

Patching in 11885 with runtime guards and release notes

Risk Level: Medium (changes to cert matching)
Testing: new unit test
Docs Changes: n/a
Release Notes: inline
Runtime guard: envoy.reloadable_features.fix_wildcard_matching

Signed-off-by: Yann Soubeyrand <yann.soubeyrand@camptocamp.com>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@istio-testing istio-testing merged commit f68ec04 into istio:release-1.6 Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants