Recast forking with capture require #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamestalmage this answers my question on #77, great work -- excited to get some of this work merged, and to then concentrate on better Windows support. |
|
Thanks so much @jamestalmage! @bcoe: Any idea when we might expect to see this merged? |
|
#89 needs to get merged first. |
(cherry picked from commit f9185aa)
c554384 to
4a337a9
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well this was easy!
This is #89, with with one commit from cherry picked from #77 (unmodified, not even a conflict!).
If nothing else, it's confirmation our testing strategy is moving in the right direction.
Now that I have
capture-requireactually working with something beyond it's own test suite, I guess it is time to publish it for real.