Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crash reporting readme #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

issackjohn
Copy link
Owner

@issackjohn issackjohn commented Jan 23, 2025

This pull request includes updates to the CrashReporting/AddStackToCrashReports.md document to provide clearer guidance on handling call stacks in crash reports.

Privacy Enhancements:

  • Included feedback on mitigating privacy issues by either omitting JavaScript call stacks with extension scripts or prompting users with explanations about sensitive information.

Clarifications on Call Stack Handling:

  • Provided additional context on why an explicit opt-in is required for sites to capture call stacks, aligning with privacy concerns.

Document Formatting:

  • Added spacing to improve readability and structure of the document. [1] [2]

@issackjohn
Copy link
Owner Author

@sethbrenith could I get your review of this? If it looks good to you i'll open a PR on the official repo for review.

@issackjohn issackjohn marked this pull request as ready for review January 23, 2025 23:20
@issackjohn
Copy link
Owner Author

issackjohn commented Jan 23, 2025

Context

https://groups.google.com/a/chromium.org/g/blink-dev/c/5W-TJDTz7pE/m/pIftgg2wCgAJ --> Asked to clarify so I'm clarifying.

w3ctag/design-reviews#981 --> I'm incorporating their feedback in the explainer

@issackjohn issackjohn force-pushed the issackjohn/update-crash-reporting-explainer branch from 56ffd81 to a4dacc1 Compare January 24, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants