Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dicom FA to Siemens XML #129

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Added dicom FA to Siemens XML #129

merged 1 commit into from
Jan 27, 2025

Conversation

mxlutz
Copy link
Contributor

@mxlutz mxlutz commented Aug 17, 2023

On our NumarisX System (XA61) using IsmrmrdParameterMap_Siemens_NX.xsl Paramter Map (default) the flipAngle_deg was not written into the ismrmrd header. The relevant part of the XSL is this:

                </xsl:for-each> 
                <xsl:for-each select="siemens/DICOM/adFlipAngleDegree">
                <xsl:if test=". &gt; 0">
                        <flipAngle_deg>
                            <xsl:value-of select="." />
                        </flipAngle_deg>
                    </xsl:if>
                </xsl:for-each>

The siemens/DICOM/adFlipAngleDegree is not defined in the Siemens default parameter map.

Is there a specific reason for that or would it make sense to just include it here? In the VB17 XML file it is included.

@schuenke
Copy link

We had the same problem with XA20. I will check if this solves the issue.

@hansenms
Copy link
Member

@kspaceKelvin can you take a look.

@fzimmermann89
Copy link

Any news here?

@kspaceKelvin
Copy link
Contributor

Looks good to me!

@cenarius1985
Copy link

i have a problem with of conversion: Software version: syngo MR XA60
Protocol name: Initialized by sequence
Detected Numaris/X version: 60
the array conversion is not coherent

@fzimmermann89
Copy link

This does not seem related to this PR, correct?

Could we move forward here?
Is anything else needed?
Can we help?

Cheers from PTB Berlin

@fzimmermann89
Copy link

Another friendly reminder to consider merging this.

Thanks!

@hansenms
Copy link
Member

@naegelejd

@naegelejd
Copy link
Contributor

We need to retrigger the build pipeline, FYI.

@naegelejd naegelejd closed this Jan 27, 2025
@naegelejd naegelejd reopened this Jan 27, 2025
@naegelejd naegelejd merged commit 8854d00 into ismrmrd:master Jan 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants