realm/mm: Correct setting of RIPAS=EMPTY on ASSIGNED_EMPTY RTTEs #425
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rayhan Faizel <rayhan.faizel@gmail.com>
nook1208
approved these changes
Apr 2, 2025
nook1208
reviewed
Apr 2, 2025
Comment on lines
384
to
-387
| if ripas as u64 == invalid_ripas::EMPTY { | ||
| new_s2tte |= bits_in_reg(S2TTE::INVALID_RIPAS, invalid_ripas::EMPTY); | ||
|
|
||
| if s2tte.is_unassigned_empty() { |
There was a problem hiding this comment.
if RTT_SET_RIPAS were to be run on ASSIGNED_EMPTY RTTEs with the requested RIPAS being EMPTY
I think this is not the case that you mention. The current code (AS-IS code) is from UNASSIGNED_EMPTY to UNASSIGNED_EMPTY which it means do nothing. Although that's not a problem, It looks good to use 'continue' in the
'else' condition like you did 👍
And it seems that the case which is from UNASSIGNED_RAM to UNASSIGNED_EMPTY was missing. It's nice to be added. Thank you !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if RTT_SET_RIPAS were to be run on ASSIGNED_EMPTY RTTEs with the requested RIPAS being EMPTY, the HIPAS would unexpectedly change to UNASSIGNED. The expected behaviour is that the entry states should remain unchanged.
To fix this, the PR does the following:
This will hence mirror the code where the requested RIPAS is RAM instead.