Python 3.9 #3611
Python 3.9 #3611
Conversation
Including PyTorch Ops and TF ops Upgrade pybind11 to v2.6.2 to fix issue with Python 3.9.0 Define __hash__ if __eq__ is defined and need storage in dict or set. python tests pass
Remove redundant POSITION_INDEPENDENT_CODE (everything is PIC in Open3D now). Submodules are shallow by default
Build 3.9 wheels in master Install TF 2.5 for Python 3.9, else stay with 2.4.1 Temp switch from 3.6 -> 3.9 for testing, since only one Python version is used during PR CI
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
…o ssheorey/python-3.9
TF update to 2.5.0 for all Python versions for consistency.
There was a problem hiding this comment.
Reviewed 6 of 13 files at r2, 9 of 13 files at r3, 1 of 1 files at r4.
Reviewable status: 16 of 19 files reviewed, 1 unresolved discussion (waiting on @ssheorey and @yxlao)
CMakeLists.txt, line 513 at r4 (raw file):
# Convenience function to set important target properties function(open3d_set_global_properties target) # Libraries need to be compiled with position independent code
This change does not seem to be related to python 3.9. Is setting PIC here superfluous?
There was a problem hiding this comment.
Reviewable status: 16 of 19 files reviewed, 1 unresolved discussion (waiting on @benjaminum and @yxlao)
CMakeLists.txt, line 513 at r4 (raw file):
Previously, benjaminum (Benjamin Ummenhofer) wrote…
This change does not seem to be related to python 3.9. Is setting PIC here superfluous?
Yes, it's set globally (as part of security settings) on line 288 for all targets.
There was a problem hiding this comment.
Reviewable status: 16 of 19 files reviewed, all discussions resolved (waiting on @yxlao)
Python 3.9 support.
Tensorflow bump 2.4.1 -> 2.5.0.
PyTorch bump 1.7.1 -> 1.8.1 (LTS)
Trigger fatal error during build if user tries to build for PyTorch<1.8.0 with Python 3.9 due to
pytorch/pytorch#50014
Closes #3065
This change is