Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for following symlinks #148

Closed
wants to merge 1 commit into from

Conversation

wesleycho
Copy link

This adds optional support for following symlinks with * and ** patterns.

Fixes #142

@wesleycho wesleycho force-pushed the feat/following-symlinks branch 2 times, most recently from 352ec6f to 967acc5 Compare December 20, 2014 17:02
This adds support for following symlinks with * and ** patterns.

Fixes isaacs#142

Fix option name to preferred name, add sync version test

Fix sync test with actual test, fix old prop name

Fix tests, split off to new file
@wesleycho wesleycho force-pushed the feat/following-symlinks branch from 967acc5 to 5194dd2 Compare December 20, 2014 17:29
@yocontra
Copy link

Any thoughts on this @isaacs ?

@isaacs
Copy link
Owner

isaacs commented Dec 30, 2014

It looks like this is confusing options.realpath and options.follow.

options.realpath should make it return the realpath rather than the symlink. But, it should not change the symlink-following behavior.

options.follow should make it follow symlinks until it hits ELOOP, like glob 3.x did. But it should not cause it to realpath the results.

These should be two separate patches, each with separate tests and docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to return real paths for symlinks
3 participants