-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question Finders #1305
Open
sjd210
wants to merge
20
commits into
redesign-2024
Choose a base branch
from
redesign/question-finder
base: redesign-2024
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Question Finders #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## redesign-2024 #1305 +/- ##
=================================================
+ Coverage 36.53% 36.66% +0.12%
=================================================
Files 472 472
Lines 20724 20587 -137
Branches 6795 6765 -30
=================================================
- Hits 7572 7548 -24
+ Misses 13114 13001 -113
Partials 38 38 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new question finder page layouts and styling.
I'm still not entirely happy with the actual filter panel specifics - we probably ought to change some font size/spacing/animation/etc. still to bring them more in-line with the designs - however I've been working on this for far too long without anyone else's eyes on it so I won't mess with these quite yet.
Probably the most significant implication of this branch for the redesign outside the QF pages themselves is that I've changed
StyledCheckbox
logic to use the new Figma iconset for Phy. Some of it is still probably quite messy (e.g. I've used anicon-checkbox-bg
element to colour the background of an empty box, but thebackground
property to do so on a partial box)Points to note:
The backend will need an update at some point in the future to be able to search across subject/field/topic lines. In this example case, anything from Maths OR Ecosystems as these are the leaf nodes. They are currently being sent to the API in the same 2D array format as before, but this can change fairly easily depending on how we implement it.
The books on a QF page are filtered depending on page context. I've manually labelled them here, but we might want a universal constant for these instead EDIT: This has been done on the teacher dashboard branch. Shouldn't be hard to copy it over.
Question finder filters are stored in the URL (so it can be linked to, maintained on a hard reload, etc). Right now this includes the subject and stage for the current page context. I've left this as-is for now, but we could probably rewrite some of that logic to remove the page-inherent filters from the URL but still maintain the current behaviour.