Ada core and advanced tagging #1014
Conversation
If a topic or concept is not on a users specification display the tag as "core" or "advanced" based on prior tagging. This prefers "core" over "advanced" and only shows "advanced" if "core" is not present. If a user has not set their preferences every tag is displayed as "core" or "advanced". To accomodate this, if a user has not set their preferences , on Ada, they have a new "none" stage and examboard to distinguish from deliberately selected "all".
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1014 +/- ##
==========================================
- Coverage 37.16% 37.12% -0.05%
==========================================
Files 420 420
Lines 18486 18532 +46
Branches 5424 6085 +661
==========================================
+ Hits 6871 6880 +9
+ Misses 11576 11033 -543
- Partials 39 619 +580 ☔ View full report in Codecov by Sentry. |
Discrepancies between accordions and topic summary links meant the two behaved differently when they should behave the same. The logic for deciding colour and label has been pushed in `stringifyAudience` to keep behaviour consistent. Additionally, support for intentionally chosen Core and Advanced stages has been added.
# Conflicts: # src/app/components/elements/inputs/UserContextAccountInput.tsx
| @@ -53,7 +54,7 @@ function UserContextRow({ | |||
| const onlyOneAtThisStage = existingUserContexts.length === 0 || existingUserContexts.filter(uc => uc.stage === e.target.value).length === 1; | |||
| const possibleExamBoards = getFilteredExamBoardOptions( | |||
| {byStages: [stage || STAGE.ALL], byUserContexts: existingUserContexts, includeNullOptions: onlyOneAtThisStage | |||
| }) || [EXAM_BOARD.ALL]; | |||
| }) || [EXAM_BOARD.ADA]; | |||
There was a problem hiding this comment.
The method getFilteredExamBoardOptions returns an array of {label: string, value: EXAM_BOARD} objects, but then we have this array that just contains EXAM_BOARD.ADA and is thus a completely different type. This isn't a new problem, but I do think we should fix it.
|
I merged the Bootstrap changes into this, and I think I resolved the messy conflict correctly. However, there are type warnings in my IDE, which I think are valid and I have commented about above. |
53dc0f2 to
a351e57
Compare
If a topic or concept is not on a users specification display the tag as "core" or "advanced" based on prior tagging. This prefers "core" over "advanced" and only shows "advanced" if "core" is not present.
If a user has not set their preferences every tag is displayed as "core" or "advanced". To accomodate this, if a user has not set their preferences , on Ada, they have a new "none" stage and examboard to distinguish from deliberately selected "all".