Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated frontend tests for group management #1005

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

jacbn
Copy link
Contributor

@jacbn jacbn commented Jun 18, 2024

Adds tests to replace the need for manual E2E tests for group management.

@jacbn jacbn changed the title Add automated frontend tests for group management 1 Add automated frontend tests for group management Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.28%. Comparing base (cc04483) to head (7b893dc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1005      +/-   ##
==========================================
+ Coverage   35.72%   37.28%   +1.55%     
==========================================
  Files         420      420              
  Lines       18534    18538       +4     
  Branches     5424     6037     +613     
==========================================
+ Hits         6621     6911     +290     
+ Misses      11875    11588     -287     
- Partials       38       39       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@skyepurchase skyepurchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One test is missing for teachers to reset the password of a student

@skyepurchase skyepurchase force-pushed the improvement/frontend-groups-automated-tests branch from 4f4ba68 to b30131e Compare July 11, 2024 16:14
@skyepurchase
Copy link
Contributor

I had missed the already existing test for password reset. Will update the spreadsheet accordingly

@skyepurchase skyepurchase merged commit fa5eb1c into master Jul 16, 2024
4 checks passed
@skyepurchase skyepurchase deleted the improvement/frontend-groups-automated-tests branch July 16, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants