Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds body tracking option to ViewerCfg #1620

Merged
merged 8 commits into from
Jan 3, 2025

Conversation

KyleM73
Copy link
Contributor

@KyleM73 KyleM73 commented Jan 2, 2025

Description

Resolves Issue #1534 by adding non-root body tracking as an option in the ViewerCfg. See the issue for justification/discussion. API as follows:

  • Adds origin_type "asset_body"
  • Adds field "body_name"

When origin_type = "asset_body" and "body_name" matches a body in the asset specified in "asset_name", the viewport is configured to track the link frame of the body in world coordinates. By using the existing eye and lookat fields in ViewerCfg the additional features are enabled:

  • Tracking the end effector of an arm during manipulation (see below)
  • Tracking a fixed offset from the end effector of an arm (e.g. mimicking the view of a wrist-mounted camera)
  • Tracking a mobile base using the currently-supported workaround for lack of wheel physics by defining a virtual arm to mimic the motion of the robot

Type of change

  • New feature (non-breaking change which adds functionality)

Training Video from "Isaac-Lift-Cube-Franka-v0" after 1000 iterations.

Viewer defined as follows:

viewer = ViewerCfg(eye=(0.5, 0.5, 0.0), origin_type="asset_body", env_index=0, asset_name="robot", body_name="panda_hand")

No other changes were made from the default environment definition.

Video_1024_franka_asset_body_test.mp4

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@kellyguo11 kellyguo11 changed the title [Feature] Adds body tracking option to ViewerCfg Adds body tracking option to ViewerCfg Jan 3, 2025
kellyguo11 and others added 3 commits January 2, 2025 22:35
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Signed-off-by: Kelly Guo <kellyguo123@hotmail.com>
Signed-off-by: Kelly Guo <kellyguo123@hotmail.com>
@kellyguo11
Copy link
Contributor

Thanks for adding support for this!

@kellyguo11 kellyguo11 merged commit a29bea0 into isaac-sim:main Jan 3, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants