Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing "not" in error message in setup_vscode.py #1615

Merged
merged 4 commits into from
Jan 1, 2025
Merged

Conversation

steple
Copy link
Contributor

@steple steple commented Jan 1, 2025

Description

Adds a missing word in an error message.
Also fixes a broken link in the pull request template.

(I did not enter an issue since it seems like a tiny change, but will if you'd like me to.)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation - I don't think any are necessary.
  • My changes generate no new warnings - I doubt it, but I have not been able to install everything, I discovered this issue on my first attempt to build.
  • I have added tests that prove my fix is effective or that my feature works - Not a feature.
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file - Not sure which file that is in this case, please let me know if this is applicable.
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@steple
Copy link
Contributor Author

steple commented Jan 1, 2025

#1616 should fix the pre-commit failure.

@kellyguo11 kellyguo11 changed the title Add missing "not" in error message in setup_vscode.py Adds missing "not" in error message in setup_vscode.py Jan 1, 2025
@kellyguo11 kellyguo11 merged commit e277065 into main Jan 1, 2025
5 checks passed
@kellyguo11 kellyguo11 deleted the spleines/not branch January 1, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants