Add MaintenanceBootConfigurationRef to Server type
#262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MaintenanceBootConfigurationRef` is used to boot a `Server` into a maintenance mode. This field is superseeding the `BootConfigurationRef` which is used for a regular/discovery boot. The reason to introduce a new field here is, that in case of a `ServerClaim` claiming a `Server` the `ServerBootConfigurationRef` field is set with a reference to a `ServerBootConfiguration` which is generated out of a `ServerClaim`.
|
i have added an extra bootconfigRef myself, since I realised the same issue :) |
Nuckal777
approved these changes
Mar 12, 2025
Nuckal777
approved these changes
Mar 13, 2025
hardikdr
approved these changes
Mar 13, 2025
|
@stefanhipfel should we merge this and you rebase your changes or is it better to close this PR? |
|
Closing in favor of #265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The
MaintenanceBootConfigurationRefis used to boot aServerinto a maintenance mode. This field is superseeding theBootConfigurationRefwhich is used for a regular/discovery boot. The reason to introduce a new field here is, that in case of aServerClaimclaiming aServertheServerBootConfigurationReffield is set with a reference to aServerBootConfigurationwhich is generated out of aServerClaim./ref #208
/cc @stefanhipfel