Make Machine image field optional
#523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adracus
suggested changes
Oct 27, 2022
98e3c1a to
b2b477f
Compare
b2b477f to
dae98bb
Compare
To support non-RAM boots we want to allow to omit the `.spec.image` field in the `Machine` spec. The image in this case will be referenced by the corresponding `Volume`.
dae98bb to
f020663
Compare
adracus
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
To support non-RAM boots we want to allow to omit the
.spec.imagefield in theMachinespec. The image in this case will be referenced by the correspondingVolume.Fixed wrong references in api-references docs.
/cc @gehoern