Fix volume access management, remove provider id #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the `MVIVolumeSource` to `VolumeAccess` into the status. This is since the user should not have to supply access credentials for a `Volume` that is managed by a `StoragePool`. Instead, once reconciled, the `StoragePool` should report them in the `Status`. The `providerID` of the `Volume` has been removed again since provider ids only make sense in terms of objects that cannot be identified uniquely (`Node`, `StoragePool`, `MachinePool`) that are at the 'root' of an API tree.
afritzler
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
MVIVolumeSourcetoVolumeAccessinto the status.This is since the user should not have to supply access credentials
for a
Volumethat is managed by aStoragePool. Instead, oncereconciled, the
StoragePoolshould report them in theStatus.The
providerIDof theVolumehas been removed again since providerids only make sense in terms of objects that cannot be identified
uniquely (
Node,StoragePool,MachinePool) that are at the 'root'of an API tree.