Skip to content

Commit

Permalink
update testcases
Browse files Browse the repository at this point in the history
  • Loading branch information
ushabelgur committed Dec 20, 2024
1 parent 4312cb6 commit aba6b94
Showing 1 changed file with 11 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -91,16 +91,6 @@ var _ = Describe("MachineEphemeralVolumeController", func() {
})

It("should not delete externally managed volumes for a machine", func(ctx SpecContext) {
By("creating an undesired controlled volume")
externalVolume := &storagev1alpha1.Volume{
ObjectMeta: metav1.ObjectMeta{
Namespace: ns.Name,
GenerateName: "external-volume-",
},
Spec: storagev1alpha1.VolumeSpec{},
}
Expect(k8sClient.Create(ctx, externalVolume)).To(Succeed())

By("creating a machine")
machine := &computev1alpha1.Machine{
ObjectMeta: metav1.ObjectMeta{
Expand All @@ -109,18 +99,21 @@ var _ = Describe("MachineEphemeralVolumeController", func() {
},
Spec: computev1alpha1.MachineSpec{
MachineClassRef: corev1.LocalObjectReference{Name: machineClass.Name},
Volumes: []computev1alpha1.Volume{
{
Name: "primary",
VolumeSource: computev1alpha1.VolumeSource{
VolumeRef: &corev1.LocalObjectReference{Name: externalVolume.Name},
},
},
},
},
}
Expect(k8sClient.Create(ctx, machine)).To(Succeed())

By("creating an undesired controlled volume")
externalVolume := &storagev1alpha1.Volume{
ObjectMeta: metav1.ObjectMeta{
Namespace: ns.Name,
GenerateName: "external-volume-",
},
Spec: storagev1alpha1.VolumeSpec{},
}
_ = ctrl.SetControllerReference(machine, externalVolume, k8sClient.Scheme())
Expect(k8sClient.Create(ctx, externalVolume)).To(Succeed())

By("asserting that the external volume is not being deleted")
Consistently(Object(externalVolume)).Should(HaveField("DeletionTimestamp", BeNil()))
})
Expand Down

0 comments on commit aba6b94

Please sign in to comment.