Adapt to new MachineControllerManagerDeployment feature gate
#221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For the `Worker` controller, we do not need to do anything further other than not providing the MCM resources. The generic actuator will be adapted in subsequent commits to not manage MCM in this case. - For the `healthcheck` controller, the code will be adapted in a subsequent commit to implmenet the needed logic. - For the `controlplane` webhook, the code will be adapted in a subsequent commit to implement the needed mutation logic (currently only returns `nil`).
There is no such folder
17 tasks
|
/cc @afritzler |
afritzler
approved these changes
Jun 21, 2023
|
Any plans to release this extension within the next 1-2 weeks to get this change out? |
|
I will try to release a new version this week. Just testing some CSI and cloud-provider related things here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity
/kind enhancement
What this PR does / why we need it:
This PR adapts the extension to the new
MachineControllerManagerDeploymentfeature gate ofgardenlet. Concretely, it now optionally disables its own management ofmachine-controller-managerand only injects its provider-specific sidecar container into theDeploymentmanaged bygardenlet.Which issue(s) this PR fixes:
Part of gardener/gardener#7594
Special notes for your reviewer:
Similar to gardener/gardener#8019
Release note: