Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GetOnmetalClientAndNamespaceFromCloudProviderSecret to use Shoot namespace #167

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Refactor GetOnmetalClientAndNamespaceFromCloudProviderSecret to use Shoot namespace #167

merged 1 commit into from
Apr 21, 2023

Conversation

afritzler
Copy link
Member

Proposed Changes

Refactor GetOnmetalClientAndNamespaceFromCloudProviderSecret to use the Shoot namespace to extract the onmetal credentials from the cloudprovider secret.

@afritzler afritzler requested a review from a team as a code owner April 21, 2023 09:30
@github-actions github-actions bot added size/S controllers enhancement New feature or request labels Apr 21, 2023
@afritzler
refactor: simplify package structure and remove unused import
8a8da7e 
- Change `infra.Namespace` to `infra` in `actuator_delete.go`, `actuator_reconcile.go`, and `configvalidator.go`.
- Remove unused import in `clientutils.go`.

Signed-off-by: Andreas Fritzler <andreas.fritzler@sap.com>
@afritzler afritzler force-pushed the enh/extract-client branch from 0555cfb to 8a8da7e Compare April 21, 2023 10:09
@afritzler afritzler merged commit 0774b5d into main Apr 21, 2023
@afritzler afritzler deleted the enh/extract-client branch April 21, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
controllers enhancement New feature or request size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@afritzler