Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Shoot load balancer configuration and metallb as first provider #46

Merged
merged 8 commits into from
Oct 2, 2024
Merged

Add Shoot load balancer configuration and metallb as first provider #46

merged 8 commits into from
Oct 2, 2024

Conversation

defo89
Copy link
Contributor

@defo89 defo89 commented Sep 20, 2024

Fixes #13

@defo89 defo89 added the enhancement New feature or request label Sep 20, 2024
@defo89 defo89 requested a review from a team as a code owner September 20, 2024 17:07
@defo89 defo89 marked this pull request as draft September 20, 2024 17:07
@defo89 defo89 force-pushed the enh/add-metallb branch 2 times, most recently from 615e530 to 03f80e2 Compare September 25, 2024 09:41
@defo89 defo89 force-pushed the enh/add-metallb branch 2 times, most recently from 535a3ff to 43d8af3 Compare September 26, 2024 09:22
@defo89 defo89 marked this pull request as ready for review September 26, 2024 09:24
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 26, 2024
@afritzler afritzler changed the title add metallb Add Shoot load balancer configuration and metallb as first provider Oct 1, 2024
Nuckal777
Nuckal777 requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@Nuckal777 Nuckal777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look. 👍

@defo89 defo89 requested a review from Nuckal777 October 2, 2024 08:48
@defo89 defo89 merged commit 52f0a24 into main Oct 2, 2024
7 checks passed
@defo89 defo89 deleted the enh/add-metallb branch October 2, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

@Nuckal777 Nuckal777 Nuckal777 approved these changes

@hardikdr hardikdr Awaiting requested review from hardikdr

Assignees
No one assigned
Labels
api-change controllers documentation Improvements or additions to documentation enhancement New feature or request size/XXL
Projects
Metal Automation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metallb support
3 participants
@defo89 @afritzler @Nuckal777