Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove encode uri component #15

Merged
merged 2 commits into from
Jan 28, 2018
Merged

remove encode uri component #15

merged 2 commits into from
Jan 28, 2018

Conversation

c0ze
Copy link
Contributor

@c0ze c0ze commented Jan 27, 2018

fixes #9

@kunihiko-t I removed encodeURIComponent, as this is not being passed to a server as a query param. What do you think ?

@c0ze c0ze requested a review from kunihiko-t January 27, 2018 13:26
kunihiko-t
kunihiko-t reviewed Jan 27, 2018
View reviewed changes
Copy link

@kunihiko-t kunihiko-t left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about using encodeURL instead of encodeURIComponent?
encodeURL won't encode slash

@c0ze
Copy link
Contributor Author

c0ze commented Jan 28, 2018

Yes, just did that, thanks ! 👍

CI should be working now, gonna go ahead and merge this, and hopefuly we will have a 0.0.2 release ! 🎊

@c0ze c0ze merged commit 461e315 into master Jan 28, 2018
@c0ze c0ze deleted the 9-remove-extra-slash-at-run-function branch January 28, 2018 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunihiko-t kunihiko-t kunihiko-t left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In Run Function model, the curl command shows a second slash
2 participants
@c0ze @kunihiko-t