Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyTorch sample notebooks using latest iree-turbine code. #19658

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

ScottTodd
Copy link
Member

@ScottTodd ScottTodd commented Jan 9, 2025

Progress on iree-org/iree-turbine#28 and #18564.

  • Switch package name from shark_turbine to iree.turbine
  • Fix dynamic shapes notebook to use FxProgramsBuilder (supported, used by sharktank) instead of jittable (weird, not something we advertise in docs now)

skip-ci: not covered by presubmit CI

@ScottTodd ScottTodd added the integrations/pytorch PyTorch integration work label Jan 9, 2025
@ScottTodd
Copy link
Member Author

Ping?

Copy link
Contributor

@vinayakdsci vinayakdsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ScottTodd ScottTodd merged commit 3c963dd into iree-org:main Jan 14, 2025
24 checks passed
@ScottTodd ScottTodd deleted the samples-iree-turbine branch January 14, 2025 15:52
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I forgot that the README also inlined this sample code: https://github.com/iree-org/iree/tree/main/samples/dynamic_shapes. Will send a new PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations/pytorch PyTorch integration work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants