[Dispatch] Disable scatter fusion with producers #19565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backends don't currently support scatter fusion and will silently compile incorrect code. This should be turned off in order to prevent backends from generating incorrect results. Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
|
I made the requested change. Additionally, instead of removing the tests, I modified them to check that no fusion occurs |
MaheshRavishankar
approved these changes
Dec 27, 2024
Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
hanhanW
reviewed
Jan 6, 2025
| @@ -651,7 +651,8 @@ isFusableWithProducer(OpOperand &operand, | |||
| } | |||
|
|
|||
| // Don't fuse attention with it's producer | |||
| if (isa<IREE::LinalgExt::AttentionOp>(consumer)) { | |||
| // TODO: Enable scatter fusion when supported by backends. | |||
There was a problem hiding this comment.
Backends don't currently support scatter fusion and will silently compile incorrect code.
Is there an issue for the TODO or your comment in the PR description?
There was a problem hiding this comment.
I found an issue about fusion (#19091), but not an issue for correctness. I mainly wonder if we should allocate someone from codegen side to fix the issue.
There was a problem hiding this comment.
I think either @qedawkins or @MaheshRavishankar were going to look at this at some point. But I don't think there is a dedicated github issue for the correctness problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backends don't currently support scatter fusion and will silently compile incorrect code. This should be turned off in order to prevent backends from generating incorrect results. I don't think any users are running into this currently, but its best to keep it off for now. Similar to #19535 but for both
indicesandupdates.