Adding iree_io_file_handle_create/iree_io_file_handle_open. #19510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1bdd7a to
5f36517
Compare
5f36517 to
1dc582d
Compare
ef1ef57 to
1714860
Compare
AWoloszyn
reviewed
Dec 18, 2024
AWoloszyn
reviewed
Dec 18, 2024
AWoloszyn
reviewed
Dec 18, 2024
AWoloszyn
reviewed
Dec 18, 2024
AWoloszyn
reviewed
Dec 18, 2024
1714860 to
81efe25
Compare
These utilities are optional but an easy way to get a file handle that is compatible with the rest of IREE. This largely replaces the need for the existing file_io utilities but cleanup/unification is left for future changes. Command line tools now default to --parameter_mode=file though users can force mmap or preload. There's some flags that are available on the open that may help or hurt performance and the defaults are provisional.
1dc582d to
7642f0c
Compare
7642f0c to
fb6b582
Compare
AWoloszyn
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These utilities are optional but an easy way to get a file handle that is compatible with the rest of IREE. This largely replaces the
need for the existing file_io utilities but cleanup/unification is left for future changes.
Command line tools now default to --parameter_mode=file though users can force mmap or preload. There's some flags that are available on the open that may help or hurt performance and the defaults are provisional.