Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] GPU ukernels cleanups #19503

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[NFC] GPU ukernels cleanups #19503

merged 1 commit into from
Dec 17, 2024

Conversation

bjacob
Copy link
Contributor

@bjacob bjacob commented Dec 17, 2024

  1. Rename UKernelSpec to UKernelConfig. I was grappling for the right word, but now that it's part of LoweringConfig, it's clearer.
  2. Drop unused KernelConfig case for ukernel ops. The lowering to ukernel ops happens after KernelConfig.
  3. To stringify types, instead of using a stringstream, we can actually just use llvm::formatv.
  4. Reorganize LLVMGPUSelectUKernels.cpp to make it easier to add logic for other ukernels.

Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
@bjacob bjacob marked this pull request as ready for review December 17, 2024 17:24
@bjacob bjacob merged commit a5cf548 into main Dec 17, 2024
43 checks passed
@bjacob bjacob deleted the users/bjacob/ukernel-tweaks branch December 17, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants