[DT][NFC] Localize CPU specific encoding materialization logic. #19452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The revision moves the CPU materialization logic from Dialect/Codegen/Utils/Utils.[h|cpp] to CPUEncodingExternalModels. They were public methods during transition states. After all the CPU layout attributes are implemented, we no longer need to expose them to public. Additionally, it removes the outdated logic from MaterializeContraction pattern. And it removes the `transposeNarrowN` input argument from lowerContractionOpWithEncoding method because all the CPU backends enable the transposeNarrowN feature. Signed-off-by: hanhanW <hanhan0912@gmail.com>
This was referenced Dec 11, 2024
bjacob
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The revision moves the CPU materialization logic from Dialect/Codegen/Utils/Utils.[h|cpp] to CPUEncodingExternalModels. They were public methods during transition states. After all the CPU layout attributes are implemented, we no longer need to expose them to the public.
Additionally, it removes the outdated logic from MaterializeContractionOp pattern. And it removes the
transposeNarrowNinput argument from lowerContractionOpWithEncoding method because all the CPU backends enable the transposeNarrowN feature.