[Util] Erase state of modified ops #19187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7831527 to
eda3a5e
Compare
MaheshRavishankar
approved these changes
Nov 18, 2024
|
Is it possible this is related to #19195 in some way? |
|
This could be the case, I'll test it out |
|
This didn't seem to fix the problem that I was having unfortunately |
Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
This was hard to debug and I haven't yet been able to track down which op was modified causing the issue nor which pattern was triggering this. I was encountering the following assert during `Stream` pipeline (but not global opt): ```shell APInt.cpp:285: int llvm::APInt::compare(const APInt &) const: Assertion `BitWidth == RHS.BitWidth && "Bit widths must be same for comparison"' failed. ``` It might be worth reverting iree-org#19130 instead of this patch since I wasn't able to track this down fully. 2/2 fix for iree-org#19167. Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
This was hard to debug and I haven't yet been able to track down which op was modified causing the issue nor which pattern was triggering this. I was encountering the following assert during `Stream` pipeline (but not global opt): ```shell APInt.cpp:285: int llvm::APInt::compare(const APInt &) const: Assertion `BitWidth == RHS.BitWidth && "Bit widths must be same for comparison"' failed. ``` It might be worth reverting iree-org#19130 instead of this patch since I wasn't able to track this down fully. 2/2 fix for iree-org#19167. Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu> Signed-off-by: Giacomo Serafini <179146510+giacs-epic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was hard to debug and I haven't yet been able to track down which op was modified causing the issue nor which pattern was triggering this. I was encountering the following assert during
Streampipeline (but not global opt):It might be worth reverting #19130 instead of this patch since I wasn't able to track this down fully.
2/2 fix for #19167.